Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499341 Jan Klepek <jan.klepek@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #2 from Jan Klepek <jan.klepek@xxxxxx> 2009-05-09 02:27:13 EDT --- %build could be empty # MUST: rpmlint must be run on every package. - OK # MUST: The package must be named according to the Package Naming Guidelines - OK # MUST: The spec file name must match the base package %{name} - OK, php pear package # MUST: The package must meet the Packaging Guidelines - OK # MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines - OK # MUST: The License field in the package spec file must match the actual license. - OK # MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. - OK # MUST: The spec file must be written in American English. - OK # MUST: The spec file for the package MUST be legible. - OK # MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. - OK $ md5sum Text_Diff-1.1.0.tgz SOURCES/Text_Diff-1.1.0.tgz 9dcea8c122d2e92a90ca48b7b16a876f Text_Diff-1.1.0.tgz 9dcea8c122d2e92a90ca48b7b16a876f SOURCES/Text_Diff-1.1.0.tgz # MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - OK, builded on fc10 i386 # MUST: If the package does not successfully compile, ... - OK, # MUST: All build dependencies must be listed in BuildRequires - OK # MUST: The spec file MUST handle locales properly. - OK, no locale # MUST: Every binary RPM package (or subpackage) which stores shared library... - OK, no shared library # MUST: If the package is designed to be relocatable, - OK # MUST: A package must own all directories that it creates. - OK # MUST: A Fedora package must not list a file more than once in the spec file's %files listings. - OK # MUST: Permissions on files must be set properly. - OK # MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} - OK # MUST: Each package must consistently use macros. - OK # MUST: The package must contain code, or permissable content. - OK # MUST: Large documentation files must go in a -doc subpackage. - OK, no large documentation # MUST: If a package includes something as %doc, it must not affect the runtime of the application. - OK # MUST: Header files must be in a -devel package. - OK, no header files # MUST: Static libraries must be in a -static package. - OK, no static libraries # MUST: Packages containing pkgconfig(.pc).. - OK, no .pc files # MUST: If a package contains library files with a suffix then library files that end in .so (without suffix) must go in a -devel package. - OK, no library # MUST: In the vast majority of cases, devel packages must require the base package ... - OK, no devel package # MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. - OK, no .la # MUST: Packages containing GUI applications must include a %{name}.desktop file, - OK, no gui # MUST: Packages must not own files or directories already owned by other packages. - OK # MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} - OK # MUST: All filenames in rpm packages must be valid UTF-8. - OK Conclusion: Approved -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review