Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=499050 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-05-08 13:22:40 EDT --- Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1343552 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 68129579330a63296474101f0cd51dfb86f9f671 Daemon-Generic-0.51.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave No tests defined for Daemon::Generic extension. + Package perl-Daemon-Generic-0.51-1.fc12.noarch => Provides: perl(Daemon::Generic) = 0.51 perl(Daemon::Generic::Event) = 0.3 perl(Daemon::Generic::While1) = 0.3 Requires: perl(Carp) perl(Daemon::Generic) perl(Event) perl(Exporter) perl(File::Flock) perl(File::Slurp) perl(Getopt::Long) perl(POSIX) perl(strict) perl(warnings) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review