Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=487097 --- Comment #7 from Dave Malcolm <dmalcolm@xxxxxxxxxx> 2009-05-07 17:55:40 EDT --- I've taken Dan's work on top of Ramez's, updated it to the latest release candidate, and fixed some issues. I renamed the "Djblets" dependency to "python-djblets" to reflect the change I proposed in bug 487098. Hope this is all OK. Updated specfile is here: http://people.redhat.com/dmalcolm/python/ReviewBoard.spec Updated SRPM is here: http://people.redhat.com/dmalcolm/python/ReviewBoard-1.0-0.4.rc1.src.rpm Output from rpmlint is clean on the SRPM, and on the built RPM gives the output: ReviewBoard.noarch: E: non-executable-script /usr/lib/python2.4/site-packages/reviewboard/scmtools/testdata/svn_repo/hooks/post-lock.tmpl 0644 ReviewBoard.noarch: E: non-executable-script /usr/lib/python2.4/site-packages/reviewboard/scmtools/testdata/svn_repo/hooks/pre-lock.tmpl 0644 ReviewBoard.noarch: E: non-executable-script /usr/lib/python2.4/site-packages/reviewboard/contrib/tools/post-commit 0644 ReviewBoard.noarch: E: non-executable-script /usr/lib/python2.4/site-packages/reviewboard/scmtools/testdata/svn_repo/hooks/post-unlock.tmpl 0644 ReviewBoard.noarch: E: non-executable-script /usr/lib/python2.4/site-packages/reviewboard/scmtools/testdata/svn_repo/hooks/post-revprop-change.tmpl 0644 ReviewBoard.noarch: E: non-executable-script /usr/lib/python2.4/site-packages/reviewboard/scmtools/testdata/svn_repo/hooks/start-commit.tmpl 0644 ReviewBoard.noarch: E: non-executable-script /usr/lib/python2.4/site-packages/reviewboard/scmtools/testdata/svn_repo/hooks/pre-commit.tmpl 0644 ReviewBoard.noarch: E: non-executable-script /usr/lib/python2.4/site-packages/reviewboard/contrib/conf/reviewboard.fcgi.in 0644 ReviewBoard.noarch: W: devel-file-in-non-devel-package /usr/lib/python2.4/site-packages/reviewboard/diffviewer/testdata/new_src/foo.c ReviewBoard.noarch: E: zero-length /usr/lib/python2.4/site-packages/reviewboard/scmtools/testdata/svn_repo/db/write-lock ReviewBoard.noarch: E: non-executable-script /usr/lib/python2.4/site-packages/reviewboard/scmtools/testdata/svn_repo/hooks/post-commit.tmpl 0644 ReviewBoard.noarch: E: non-executable-script /usr/lib/python2.4/site-packages/reviewboard/scmtools/testdata/svn_repo/hooks/pre-unlock.tmpl 0644 ReviewBoard.noarch: E: non-executable-script /usr/lib/python2.4/site-packages/reviewboard/scmtools/testdata/svn_repo/hooks/pre-revprop-change.tmpl 0644 ReviewBoard.noarch: W: devel-file-in-non-devel-package /usr/lib/python2.4/site-packages/reviewboard/diffviewer/testdata/orig_src/foo.c These appear to all be example files or test data, and thus I don't think they're real problems. Caveat: I'm doing this all on a RHEL5 box, rather than specifically Fedora. How's this looking? Ramez, do you still want to own this package? Dan? I'd be happy to co-maintain. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review