Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=458090 Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |jochen@xxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #22 from Jochen Schmitt <jochen@xxxxxxxxxxxxxxx> 2009-05-07 13:54:46 EDT --- Good: + Base name of the SPEC files matches with package name. + Package name fits with the naming convention * URI tag shows on proper project homepage * Could downloads sources with spectool -g + Sources in Source package matches with upstream (md5sum: 02174b85917b68ac5f681a4f117b7bd LuxRender_v05_Source.zip 7cb0920c7c77ebaa5d7a721be124a27f LuxBlend_v05_Blender_Exporter.zip) * Package contains several subpackage + Package contains valid license tag + License Tag contains GPLv3+ and BSD as valid OpenSource licenses + Upstream sources contains verbatins copy of the licenses + License note in source files seems to mach license tag + Consistently usage of rpm macros + Proper BuildRoot tag + Buildroot will be cleaned on the start of %install and %clean + Rpmlint is silent on source RPM. + RPM_OPT_FLAGS will honoured. + Debuginfo package contains sources + Koji scratch build works fine. * Local build works fine. * Local install and uninstall works fine. + Start of the application works fine + Menu entry is ok + %files stanza contains no duplicates + Package contains proper %Changelog entries TODO - Please set blender requirement to bleder >= 2.48a-21 to make sure, that the script are available in a corret was. - Why you add an Req rom the devel-docs package to the main Package. - Please moveove content of the %doc stanza of the libs subpackage to the main package - Rpmlint complaints on binary RPMs: pmlint LuxRender-* LuxRender.x86_64: W: no-documentation LuxRender-blender.x86_64: W: no-documentation LuxRender-blender.x86_64: E: wrong-script-interpreter /usr/share/blender/scripts/LuxBlend_0.1.py "BPY" OK.: Blender specific LuxRender-blender.x86_64: E: non-executable-script /usr/share/blender/scripts/LuxBlend_0.1.py 0644 Should be fixed. LuxRender-blender.x86_64: E: wrong-script-end-of-line-encoding /usr/share/blender/scripts/LuxBlend_0.1.py Should be fixed. LuxRender-core.x86_64: W: no-documentation OK. LuxRender-devel.x86_64: W: no-documentation OK. LuxRender-lib.x86_64: W: shared-lib-calls-exit /usr/lib64/liblux.so.1.0 exit@xxxxxxxxxxx May be OK. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review