Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226322 Daniel Novotny <dnovotny@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|needinfo?(dnovotny@xxxxxxxx | |om) | --- Comment #12 from Daniel Novotny <dnovotny@xxxxxxxxxx> 2009-05-06 09:58:21 EDT --- hello, I made the suggested .spec changes: * added purpose comments to all patches * fixed URL * fixed %defattr as for the others: > * Not necessary to define globally when used only for make configure and autoreconf doesn't use those? I'm not sure... > * don't mix variable and macro style as far as I can see, there's only variable style for those two variables output: http://people.fedoraproject.org/~dnovotny/psmisc.review.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review