Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=491497 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #1 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2009-05-06 06:25:37 EDT --- Just some quick comments on your spec file - Don't mix '$RPM_BUILD_ROOT' and '%{buildroot}' http://fedoraproject.org/wiki/Packaging:Guidelines#Using_.25.7Bbuildroot.7D_and_.25.7Boptflags.7D_vs_.24RPM_BUILD_ROOT_and_.24RPM_OPT_FLAGS - There are two '%defattr(-, root, root, -)' entries - You are working with users/group. Aren't 'Requires(pre): /usr/sbin/useradd /usr/sbin/groupadd' and 'Requires(postun): /usr/sbin/userdel /usr/sbin/groupdel' missing? - Same with the service. 'Requires(post): chkconfig' and 'Requires(preun): chkconfig' - disttag is not needed in changelog, you can remove '.fc10' there -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review