[Bug 498703] Review Request: perl-Term-Completion - Read one line of user input, with convenience functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=498703


Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx>  2009-05-03 11:48:35 EDT ---
Review:
+ package builds in mock (rawhide i586).
koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1332443
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
6f5920facb98b20923559f57608bb6ef  Term-Completion-0.91.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test outputs
Files=9, Tests=100,  1 wallclock secs ( 0.09 usr  0.02 sys +  0.70 cusr  0.08
csys =  0.89 CPU)

+ Package perl-Term-Completion-0.91-1.fc12.noarch =>
Provides: perl(Term::Completion) = 0.91 perl(Term::Completion::Multi) = 0.90
perl(Term::Completion::Path) = 0.90 perl(Term::Completion::_POSIX)
perl(Term::Completion::_readkey) perl(Term::Completion::_stty)
perl(Term::Completion::_termsize)
Requires: perl(Carp) perl(Exporter) perl(File::Spec) perl(IO::Handle)
perl(POSIX) perl(Term::ReadKey) perl(base) perl(strict) perl(warnings)

 APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]