Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498772 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-05-03 11:36:40 EDT --- Review: + package builds in mock (rawhide i586). lkoji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1333703 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 1bd5edb5df1530fb71c4c3c5ba22916a Catalyst-Plugin-Cache-0.08.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs Files=6, Tests=60, 2 wallclock secs ( 0.07 usr 0.02 sys + 1.63 cusr 0.17 csys = 1.89 CPU) + Package perl-Catalyst-Plugin-Cache-0.08-2.fc12.noarch-> Provides: perl(Catalyst::Plugin::Cache) = 0.08 perl(Catalyst::Plugin::Cache::Backend) perl(Catalyst::Plugin::Cache::Backend::Memory) perl(Catalyst::Plugin::Cache::Choose::KeyRegexes) perl(Catalyst::Plugin::Cache::Curried) perl(Catalyst::Plugin::Cache::Store::Memory) Requires: perl(Carp) perl(Catalyst::Plugin::Cache::Backend::Memory) perl(Catalyst::Plugin::Cache::Curried) perl(Catalyst::Utils) perl(MRO::Compat) perl(Scalar::Util) perl(Storable) perl(base) perl(strict) perl(warnings) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review