Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498744 Hans de Goede <hdegoede@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |hdegoede@xxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Hans de Goede <hdegoede@xxxxxxxxxx> 2009-05-03 10:48:42 EDT --- Hi, FULL review done, here are the results: MUST FIX: -add comments how *exactly* to generate the tarbal from svn -License should be GPLv2+ -Patch Makefile to not pass -O3 to gcc, that is not part of the default Fedora CFLAGS Should FIX: -Preserve timestamps of docs while converting them, replace: iconv -f iso8859-1 -t utf-8 $f >$f.conv && mv $f.conv $f with: iconv -f iso8859-1 -t utf-8 $f >$f.conv touch -r $f $f.conv mv $f.conv $f -Is the BuildRequires: subversion really needed ? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review