Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498214 Christoph Wickert <fedora@xxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Christoph Wickert <fedora@xxxxxxxxxxxxxxxxxxxx> 2009-05-03 07:09:15 EDT --- (In reply to comment #3) > cp -a DOES preserve timestamps. Sorry, seems like it was to late yesterday. > I also removed the included cclib, to install you need > https://bugzilla.redhat.com/show_bug.cgi?id=497338 Damn, I missed something really obvious. > http://theory.physics.helsinki.fi/~jzlehtol/rpms/gausssum.spec > http://theory.physics.helsinki.fi/~jzlehtol/rpms/gausssum-2.1.6-2.fc10.src.rpm Ok - Requirements look sane, should be covered by cclib. Too bad this package now pulls in PyQt4 and it's deps. OK - Package builds in mock. OK - Package includes a desktop file. OK - Help -> Documentation works OK - File -> Settings -> Gnuplut correct, Test works Issues: You are installing an icon into /usr/share/icons/hicolor/, but you are not running the gtk-update-icon-cache srciptlet. I would simply install to /usr/share/pixmaps, then you don't need to require hicolor-icon-theme. Desktop file: "Analyze output of Quantum Chemistry packages" is a comment, not a GenericName. GenericName would be something like "Quantum computation analyzer" or just GaussSum. Add more categories to allow nested menus: Chemistry (?), DataVisualization and Physics are good candidates I guess, see http://standards.freedesktop.org/menu-spec/latest/apa.html IMHO you should just symlink GaussSum.py instead of excluding it's pyc and pyo as you did in the previous package, but this is up to you. Apply fixes and consider this package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review