Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=495902 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #1 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2009-05-02 14:20:17 EDT --- Just some quick comments on your spec file. - The license is GPLv2+ (see source header, 'either version 2 of the License, or * (at your option) any later version.') not GPLv2 - 'Release: 1' should be 'Release: 1%{?dist}' - 'Source0' should point to the upstream location of the source tarball if possible https://fedoraproject.org/wiki/Packaging/SourceURL - There is 'gcc' mentioned in the 'BuildRequires' this is not needed https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 - Please replace 'BuildArch' with 'ExcludeArch' https://fedoraproject.org/wiki/Architectures#ExcludeArch_.26_ExclusiveArch - 'Provides: olpc-kbdshim = 4' is not needed https://fedoraproject.org/wiki/How_to_create_an_RPM_package#Other_tags - README is missing in %doc - You must use macros in the %files section https://fedoraproject.org/wiki/Packaging:Guidelines#Macros -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review