Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=481701 Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #6 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-05-02 12:51:58 EDT --- OK, I checked everything including the license mess (upstream did a good job in classifying things though). There are a few minor issues and questions: ! The md5sum you put in the specfile is wrong. But you don't need to put an md5sum there anyway. * Each package must consistently use macros: %{__python} needs to be converted to python * The new guidelines prefer usage of %global over %define. See: http://fedoraproject.org/wiki/Packaging/Python#System_Architecture ? Is there a way of generating/packaging the API docs? How about the docs directory? ? How about the examples directory? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review