Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497756 --- Comment #12 from Andrew Overholt <overholt@xxxxxxxxxx> 2009-05-01 12:33:28 EDT --- Here's a mostly-complete review with a few questions: - naming and licensing are fine - versioning is fine - where does Source3 (the build.xml) come from? what about Patch1 (-jar-up)? - I didn't know you could use the %setup macro more than once but I don't see anything in the guidelines about not doing this - a comment other than "apply patches" would be useful before the %patch macros. I personally like to say what each patch is doing - lines 16, 99, 101, 108, 109, 110 are all > 80 characters - the Makefile(s) they provide do something weird with debuginfo ... or /usr/bin/lpg isn't executable so strip-debuginfo isn't run on it? I have to go over the non-Java packaging guidelines for the C++ stuff. That'll take me a while but I'll get back to you when I'm done. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review