Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497759 arthurguru <arthurg.work@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthurg.work@xxxxxxxxx --- Comment #3 from arthurguru <arthurg.work@xxxxxxxxx> 2009-05-01 01:08:04 EDT --- Hi Silas, please treat this review as advisory as it's my first review of someone elses work against the Fedora Guidelines. MUST: rpmlint must be run on every package. The output should be posted in the review. - rpmlint funcshell-0.0.1-1.src.rpm -Ok -rpmlint funcshell-0.0.1-1.noarch.rpm -Not OK - rpm package does not build on my system. Processing files: funcshell-0.0.1-1 error: File not found by glob: /var/tmp/funcshell-0.0.1-1-root-root/usr/lib/python2.5/site-packages/funcshell-0.0.1-*.egg-info - Not OK MUST: The package must be named according to the Package Naming Guidelines . - OK MUST: The spec file name must match the base package %{name} - OK MUST: The package must meet the Packaging Guidelines - Doesn’t build (on my system) - Not OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines . - OK MUST: The License field in the package spec file must match the actual license. - OK MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc - OK MUST: The spec file must be written in American English. -OK MUST: The spec file for the package MUST be legible. - OK MUST: The sources used to build the package must match the upstream source - OK MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. - Doesn’t build on my system Must: Python eggs must be built from source. They cannot simply drop an egg from upstream into the proper directory. - No egg-info files generated. Must: If egg-info files are generated by the modules build scripts they must be included in the package. - No egg-info files generated, package is expecting them. - Not OK MUST: If the package does not successfully compile, build or work on an architecture - See above - Not OK MUST: All build dependencies must be listed in BuildRequires - Missing python requirement in spec file: BuildRequires: python - Not OK MUST: The spec file MUST handle locales properly. - OK, no locales available MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. - OK, no shared library available MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. - OK, no relocatable package MUST: A package must own all directories that it creates. - OK MUST: A Fedora package must not list a file more than once in the spec file's %files listings. - OK MUST: Permissions on files must be set properly. - OK MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). - OK MUST: Each package must consistently use macros. URL: and Source0: could be more consistent with %{name} macro - OK MUST: The package must contain code, or permissable content. - OK MUST: Large documentation files must go in a -doc subpackage. - OK, no large documentation MUST: If a package includes something as %doc, it must not affect the runtime of the application. - OK MUST: Header files must be in a -devel package. - OK, no header files MUST: Static libraries must be in a -static package. - OK, no static libraries MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). - OK, no .pc files MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. - OK, no library files MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency: Requires: %{name} = %{version}-%{release} - OK, no devel package MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. - OK, no .la files MUST: Packages containing GUI applications must include a %{name}.desktop file - OK, no gui available MUST: Packages must not own files or directories already owned by other packages. - OK MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). - OK MUST: All filenames in rpm packages must be valid UTF-8. Regards, Arthur Gouros - OK -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review