Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498136 Tom "spot" Callaway <tcallawa@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tcallawa@xxxxxxxxxx --- Comment #2 from Tom "spot" Callaway <tcallawa@xxxxxxxxxx> 2009-04-30 16:59:17 EDT --- A few things worth noting: * You really, really, really don't need those macro defines at the top. Half of them aren't used. Just put the versions in the BuildRequires explicitly. * Fix the patch to apply without fuzz, please? :) Then, drop the default_fuzz macro define. * The %{gettext_package} macro is fine, but please use %global instead of %define. * Are you sure --disable-pulseaudio is correct? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review