Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498413 --- Comment #5 from Thomas Sailer <t.sailer@xxxxxxxxxxxxxx> 2009-04-30 16:32:19 EDT --- I've updated the package: Spec URL: http://sailer.fedorapeople.org/vfrnav.spec SRPM URL: http://sailer.fedorapeople.org/vfrnav-0.3-4.fc11.src.rpm (In reply to comment #4) > You should change that group too to something appropriate. Ugh. Oversaw that one. Fixed now. > Like this: > %dir %{_datadir}/%{name} > %{_datadir}/%{name}/* Yes I know I can use wildcards, however I'd like to get notified (by the unpackaged files check) if something changes there, so I would like to keep tne enumeration of all files in that directory. > - you are supplying desktop file but you are not installing it. > http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files Fixed (now validating them) > Desktop file supplied with vfrnav is weird - I never seen that kind of file. I > would recommend you to make your own desktop file. All of this is explained at > previous link. What is actually wierd about them? They conform to the spec as I read it... > - You are installing icons for your desktop file but you never update icon > cache. https://fedoraproject.org/wiki/PackagingDrafts/Icon_Cache Fixed, thanks! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review