Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498397 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-04-30 11:21:38 EDT --- Review: + package builds in mock (rawhide i586). koji build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1330112 + rpmlint is silent for SRPM and for RPM. + source files match upstream url e052cac4b6d55eee9a0ced5a76b5a7be Devel-REPL-1.003006.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs Files=1, Tests=17, 1 wallclock secs ( 0.03 usr 0.00 sys + 0.46 cusr 0.02 csys = 0.51 CPU) +Package perl-Devel-REPL-1.003006-1.fc12.noarch => Provides: perl(Devel::REPL) = 1.003006 perl(Devel::REPL::Error) perl(Devel::REPL::Meta::Plugin) perl(Devel::REPL::Plugin) perl(Devel::REPL::Plugin::B::Concise) perl(Devel::REPL::Plugin::Colors) perl(Devel::REPL::Plugin::Commands) perl(Devel::REPL::Plugin::Completion) perl(Devel::REPL::Plugin::CompletionDriver::Globals) perl(Devel::REPL::Plugin::CompletionDriver::INC) perl(Devel::REPL::Plugin::CompletionDriver::Keywords) perl(Devel::REPL::Plugin::CompletionDriver::LexEnv) perl(Devel::REPL::Plugin::CompletionDriver::Methods) perl(Devel::REPL::Plugin::CompletionDriver::Turtles) perl(Devel::REPL::Plugin::DDS) perl(Devel::REPL::Plugin::DumpHistory) perl(Devel::REPL::Plugin::FancyPrompt) perl(Devel::REPL::Plugin::FindVariable) perl(Devel::REPL::Plugin::History) perl(Devel::REPL::Plugin::Interrupt) perl(Devel::REPL::Plugin::LexEnv) perl(Devel::REPL::Plugin::MultiLine::PPI) perl(Devel::REPL::Plugin::NewlineHack) perl(Devel::REPL::Plugin::Nopaste) perl(Devel::REPL::Plugin::OutputCache) perl(Devel::REPL::Plugin::PPI) perl(Devel::REPL::Plugin::Packages) perl(Devel::REPL::Plugin::Packages::DefaultScratchpad) perl(Devel::REPL::Plugin::Peek) perl(Devel::REPL::Plugin::ReadLineHistory) perl(Devel::REPL::Plugin::Refresh) perl(Devel::REPL::Plugin::ShowClass) perl(Devel::REPL::Plugin::Timing) perl(Devel::REPL::Plugin::Turtles) perl(Devel::REPL::Profile) perl(Devel::REPL::Profile::Default) perl(Devel::REPL::Script) Requires: /usr/bin/env perl >= 0:5.008001 perl(B::Concise) perl(B::Keywords) perl(Data::Dump::Streamer) perl(Devel::Peek) perl(Devel::REPL) perl(Devel::REPL::Error) perl(Devel::REPL::Meta::Plugin) perl(Devel::REPL::Plugin) perl(Devel::REPL::Script) perl(File::HomeDir) perl(File::Next) perl(File::Spec) perl(Lexical::Persistence) perl(Module::Refresh) perl(Moose) perl(Moose::Role) perl(Moose::Util::TypeConstraints) perl(MooseX::AttributeHelpers) perl(PPI) perl(PPI::Dumper) perl(Scalar::Util) perl(Term::ANSIColor) perl(Term::ReadLine) perl(Time::HiRes) perl(namespace::clean) perl(strict) perl(vars) perl(warnings) suggestions: 1) Not needed BuildRequires: perl >= 1:5.8.1 APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review