Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=438588 Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |oget.fedora@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |oget.fedora@xxxxxxxxx Flag| |fedora-review? --- Comment #12 from Orcan 'oget' Ogetbil <oget.fedora@xxxxxxxxx> 2009-04-30 01:35:26 EDT --- Here are my notes for this package: - Package builds fine in koji rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=1329697 * rpmlints: zfstream-devel.x86_64: W: no-documentation zfstream.x86_64: W: no-documentation The file ChangeLog can go to %doc. I don't think it is worth packaging the LICENSE file as it doesn't say much about the license. * Patches should be explained and be submitted to upstream. Since the project seems dead, it won't hurt to bypass the submission part. But please explain in the SPEC file what the patch does. * Similarly, please give the reasoning of Source1. * Please remove the duplicate copy of minizip, which we already have in Fedora, from Source1 and adjust the BR's. Note that minizip-devel already requires zlib-devel. * The package must be named according to the Package Naming Guidelines. The upstream tarball has a different name. Why don't we use it? * No need to explicitly BR automake. libtool does and always will pull that for you. ! Please make use of the %{name} macro. * The devel package must require "bzip2-devel", "zlib-devel or minizip-devel (?)", and "pkgconfig" ? About "touch NEWS README AUTHORS": Wasn't there an --add-missing flag to automake? ! No need for blank %doc's. ! Please make the descriptions span 80 columns. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review