[Bug 497441] Review Request: mumble - Voice chat application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497441





--- Comment #51 from Igor Jurišković <juriskovic.igor@xxxxxxxxx>  2009-04-29 15:41:15 EDT ---
(In reply to comment #49)
> checking everything again:
> 
> 1. mumble-plugins also needs to Requires: %{name} = %{version}-%{release} (just
> checked it)
Fixed

> 2. i am curious if the menu entry for mumble-overlay makes sense really because
> it doesent start that way (one needs to start a binary with it.). your
> decision! ;)
It was always senseless to me but Simon told me in earlier replies that it
should be installed. I tought "well he is already a packager, he nows better
than me". Thats the reason why I was installing it. 

Its removed now.

> 3. gtk-update-icon-cache -q %{_datadir}/icons/hicolor >& /dev/null ||: is
> probably a typo -> &> /dev/null ||: 
> fixing that lets it install nearly cleanly
Fixed.

> 4. i still get the warnings from ldconfig that /usr/lib64/libmumble.so.1 is not
> a symbolic link (infact it is a hardlink)
> id suggest to remove the 2>/dev/null from /sbin/ldconfig calls because that
> just hides issues (and not even that correctly in this case)
> going to investigate the issue deeper and let you know if i figure out how to
> fix that correctly.
I think the solution for this is mine bad packaging. It looks like that
libmumble.so.x.y.z is part of mumble-overlay package. Thats why it reports it
is hardlink. Im waiting for Thorvalds reply to confirm this.

> 
> i hope that you see now that it would be quite impossible to find all issues in
> one run because you picked a really complex package there.  
Complex guy needs a complex package. :)


Anyway, I'm jobless so I have really a lot of spare time.

When Thorvald answers my previous post about libraries I'll upload a new spec.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]