[Bug 472819] Review Request: rubygem-rufus-scheduler - Scheduler for Ruby (at, cron and every jobs)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=472819





--- Comment #5 from Jussi Lehtola <jussi.lehtola@xxxxxx>  2009-04-29 15:08:50 EDT ---
- I don't know if this is normal for ruby gems, but you're using a non-standard
documentation location:

%doc %{gemdir}/doc/%{gemname}-%{version}
%doc %{geminstdir}/README.txt
%doc %{geminstdir}/CHANGELOG.txt
%doc %{geminstdir}/CREDITS.txt

Please fix this, for example by adding
 %setup -c -T

and after the install:

 mkdir doc/
 mv %{gemdir}/doc/%{gemname}-%{version} %{geminstdir}/README.txt \ 
 %{geminstdir}/CHANGELOG.txt %{geminstdir}/CREDITS.txt doc/

Then your %doc section should be just
 %doc doc/*

- The line
 Requires: ruby(abi) = 1.8
is missing. Please add this. [
http://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines ]

- You can probably drop the
 %define ruby_sitelib %(ruby -rrbconfig -e "puts Config::CONFIG['sitelibdir']")
since you're not using it anywhere.
---

rpmlint output is clean.


MUST: The package does not yet exist in Fedora. The Review Request is not a
duplicate. OK
MUST: The spec file for the package is legible and macros are used
consistently. OK
MUST: The package must be named according to the Package Naming Guidelines. OK
MUST: The spec file name must match the base package %{name}. OK
MUST: The package must be licensed with a Fedora approved license and meet the 
Licensing Guidelines. OK
MUST: The License field in the package spec file must match the actual license.
OK
MUST: The sources used to build the package must match the upstream source, as
provided in the spec URL. OK
MUST: The package MUST successfully compile and build into binary rpms. OK
MUST: Permissions on files must be set properly. OK
MUST: Clean section exists. OK
MUST: Large documentation files must go in a -doc subpackage. OK
MUST: All relevant items are included in %doc. Items in %doc do not affect
runtime of application. OK
MUST: No file conflicts with other packages and no general names. OK
MUST: Buildroot cleaned before install. OK
SHOULD: %{?dist} tag is used in release. OK

SHOULD: If the package does not include license text(s) as separate files from
upstream, the packager should query upstream to include it. NEEDSFIX

SHOULD: The package builds in mock. OK

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]