Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475017 Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #20 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-04-29 12:57:41 EDT --- Well, - For the line "javadoc -classpath ..." I recommend to use find - xargs also here, like: ------------------------------------------------------------------ find src/java -name '*.java' -print 0 \ xargs -0 javadoc -classpath \ `build-classpath nachocalendar jcalendar` -d doc ------------------------------------------------------------------ - I recommend to remove unneeded comments because it makes spec file less readable. - Please make main package own %_javadir/%name Please fix the issues above before importing. ----------------------------------------------------------- This package (l2fprod-common) is APPROVED by mtasaka ----------------------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review