Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=498216 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-04-29 11:58:28 EDT --- Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1328528 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 7ce83250ffa83ca25c40c9aaa9adc9b2 Perl-Tags-0.26.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=8, Tests=47, 4 wallclock secs ( 0.08 usr 0.03 sys + 1.51 cusr 0.16 csys = 1.78 CPU) + Package perl-Perl-Tags-0.26-1.fc12.noarch => Provides: perl(Perl::Tags) = 0.26 perl(Perl::Tags::Naive) perl(Perl::Tags::Naive::Lib) perl(Perl::Tags::Naive::Spiffy) perl(Perl::Tags::PPI) perl(Perl::Tags::Tag) perl(Perl::Tags::Tag::Constant) perl(Perl::Tags::Tag::Field) perl(Perl::Tags::Tag::Label) perl(Perl::Tags::Tag::Package) perl(Perl::Tags::Tag::Recurse) perl(Perl::Tags::Tag::Stub) perl(Perl::Tags::Tag::Sub) perl(Perl::Tags::Tag::Var) Requires: perl(Data::Dumper) perl(File::Spec) perl(Module::Locate) perl(PPI) perl(base) perl(overload) perl(strict) perl(warnings) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review