Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=496524 Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Mattias Ellert <mattias.ellert@xxxxxxxxxxxx> 2009-04-29 07:57:15 EDT --- Fedora review jorbis-0.0.17-1.fc10.src.rpm 2009-04-29 rpmlint output: [ellert@ellert jorbis]$ rpmlint 1256512409979681881233819/result/jorbis/*.rpm jorbis.spec jorbis.src:156: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/gcj/%{name} jorbis.src:157: W: libdir-macro-in-noarch-package (main package) %{_libdir}/gcj/%{name}/%{name}-%{version}.jar.* jorbis.src:170: W: libdir-macro-in-noarch-package player %{_libdir}/gcj/%{name}/%{name}-player*.jar.* jorbis.src:178: W: libdir-macro-in-noarch-package comment %{_libdir}/gcj/%{name}/%{name}-comment*.jar.* jorbis.spec:156: W: libdir-macro-in-noarch-package (main package) %dir %{_libdir}/gcj/%{name} jorbis.spec:157: W: libdir-macro-in-noarch-package (main package) %{_libdir}/gcj/%{name}/%{name}-%{version}.jar.* jorbis.spec:170: W: libdir-macro-in-noarch-package player %{_libdir}/gcj/%{name}/%{name}-player*.jar.* jorbis.spec:178: W: libdir-macro-in-noarch-package comment %{_libdir}/gcj/%{name}/%{name}-comment*.jar.* 6 packages and 1 specfiles checked; 0 errors, 8 warnings. * OK ! needs attention * rpmlint warnings are bogus - rpmlint does not understand the conditional BuildArch. * Package is named according to the guidelines * The specfile is named after the package * The package follows the guidelines for a native Java package * Package license is Fedora approved (LGPLv2+) * The README file says that the license is LGPL with no version, but that is equivalent to LGPLv2+ according to the Fedora License list * The license file (COPYING.LIB) in the sources is installed as %doc * The specfile is written in legible English * Sources matches upstream: 6141edfb16d34412a86c95a97fd4b10f jorbis-0.0.17.zip 6141edfb16d34412a86c95a97fd4b10f SRPM/jorbis-0.0.17.zip * Package builds in mock (Fedora 10) * BuildRequires are sane * No shared libraries * Package owns the directories it creates ! The jars in -comment and -player are also in main (duplicate files) * Permissions are sane and %files has %defattr * %clean clears buildroot * Consistent use of macros * Documentation in -javadoc package * %doc is not runtime essential * subpackages require main with fully versioned dependencies * Package does not own other's directories * %install clears buildroot * Installed filenames are valid UTF-8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review