Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=494148 Michael Schwendt <bugs.michael@xxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|177841(FE-NEEDSPONSOR) | Flag|fedora-review? |fedora-review+ --- Comment #22 from Michael Schwendt <bugs.michael@xxxxxxx> 2009-04-29 06:21:57 EDT --- > soci-3.0.0-5.fc10.src.rpm APPROVED So you can squash remaining issues in pkg cvs, which will be more convenient than going through the upload-bugzilla-review cycle. [...] With a caveat, though, as the conditional build options don't seem to work [yet]: configure: WARNING: unrecognized options: --disable-backend-empty, --disable-backend-sqlite3 And although it recognises the other --disable-backend options, it ignores them and still builds various backends if the needed -devel pkgs are installed. E.g. --without mysql ends with RPM build errors: Installed (but unpackaged) file(s) found: /usr/include/soci/backends/mysql/soci-mysql.h /usr/lib/libsoci_mysql.so /usr/lib/libsoci_mysql.so.3 /usr/lib/libsoci_mysql.so.3.0.0 Unless you can disable the backends at "configure"-time, you could add "BuildConflicts: mysql-devel" to enforce uninstalling unwanted -devel pkgs. ;o) [...] > %define mydocs __tmp_docdir Not used anywhere. * The many %{?with_foo:...} switches throughout the spec file could be grouped together and could be replaced with a much more readable %if/%endif block that covers everything for each conditional subpkg except the %build/%install sections. In other words, for e.g. MySQL you would end up with: %if %{with mysql} %package mysql ... %description mysql ... %files mysql ... %post mysql -p /sbin/ldconfig %postun mysql -p /sbin/ldconfig ... %package mysql-devel ... %description mysql-devel ... %files mysql-devel ... %endif -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review