Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492744 Jussi Lehtola <jussi.lehtola@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jussi.lehtola@xxxxxx --- Comment #3 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-04-28 09:09:51 EDT --- Same things here: - don't use macros where they aren't needed (python, cp, mv, rm and so on) - BR should be python-devel, not python [BR: python, python-devel is also redundant since python-devel requires python] - Don't use filelists in install phase, but list the files and directories explicitly in the %files section (you can use wildcards, though), also %defattr should be (-,root,root,-) - Remove empty %post and %postun sections -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review