Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497660 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-04-28 01:05:11 EDT --- Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1325834 + rpmlint output for SRPM and for RPM. perl-MIME-Charset.noarch: E: useless-provides perl(MIME::Charset) =>This package provides 2 times the same capacity. It should only provide it once. remove this. + source files match upstream url 22a140a7f323518301d9998bf50e2e17 MIME-Charset-1.006.2.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=7, Tests=77, 0 wallclock secs ( 0.08 usr 0.01 sys + 0.43 cusr 0.04 csys = 0.56 CPU) + Package perl-MIME-Charset-1.006.2-1.fc12.noarch => Provides: perl(MIME::Charset) perl(MIME::Charset) = 1.006.2 perl(MIME::Charset::_Compat) = 1.003 Requires: perl >= 0:5.004 perl >= 0:5.005 perl(Carp) perl(Exporter) perl(strict) perl(vars) Suggestions: 1) remove perl(MIME::Charset) provides in SPEC. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review