[Bug 497441] Review Request: mumble - Voice chat application

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=497441





--- Comment #27 from Rudolf Kastl <che666@xxxxxxxxx>  2009-04-27 11:42:25 EDT ---
issues left i can currently see:

1. mumble.logrotate needs to be copiedto %{buildroot}%{_sysconfdir}/logrotate.d

2. you might want to use runuser within the init script to get the daemon
started as $DAEMONUSER

3. i still see /sbin/ldconfig: /usr/lib64/libmumble.so.1 is not a symbolic link
(1.1.8-5)

4. the protocol file is kde4 stuff and needs to go to
%{_datadir}/kde4/services/%{name}.protocol

5. murmur.conf (from scripts directory) needs to go to
%{buildroot}%{_sysconfdir}/dbus-1/system.d/murmur.conf

6. id recommend adding no-embed-qt-translations because it gets rid of embedded
qt translation probs.

7. id recommend adding no-update because we want to have users update the rpm
way anyways.

8. adding DEFINES+=PLUGIN_PATH=%{_libdir}/%{name} cant really hurt

9. DEFINES+=DEFAULT_SOUNDSYSTEM=PulseAudio also makes sense to me.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]