Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497441 --- Comment #14 from Igor Jurišković <juriskovic.igor@xxxxxxxxx> 2009-04-25 15:50:09 EDT --- Nah, don't like to wait. So I did almost everything as I think it should be. -------------------------------------------- MUMBLE: [makerpm@localhost SPECS]$ rpmls ../RPMS/i386/mumble-1.1.8-2.fc9.i386.rpm -rwxr-xr-x /usr/bin/mumble -rwxr-xr-x /usr/lib/libmumble.so -rwxr-xr-x /usr/lib/libmumble.so.1 -rwxr-xr-x /usr/lib/libmumble.so.1.1 -rwxr-xr-x /usr/lib/libmumble.so.1.1.8 -rwxr-xr-x /usr/lib/mumble/liblink.so drwxr-xr-x /usr/share/doc/mumble-1.1.8 -rw-r--r-- /usr/share/doc/mumble-1.1.8/CHANGES -rw-r--r-- /usr/share/doc/mumble-1.1.8/LICENSE -rw-r--r-- /usr/share/doc/mumble-1.1.8/README -rw-r--r-- /usr/share/doc/mumble-1.1.8/README.Linux [makerpm@localhost SPECS]$ [makerpm@localhost SPECS]$ rpmlint ../RPMS/i386/mumble-1.1.8-2.fc9.i386.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [makerpm@localhost SPECS]$ ------------------------------------------------- MURMUR: [makerpm@localhost SPECS]$ rpmls ../RPMS/i386/murmur-1.1.8-2.fc9.i386.rpm lrw-rw-r-- /etc/mumble-server.ini -rw-rw-r-- /etc/murmur/murmur.ini -rwxr-xr-x /etc/rc.d/init.d/murmur lrwxrwxrwx /usr/bin/mumble-server lrwxrwxrwx /usr/sbin/murmur -rwxr-xr-x /usr/sbin/murmurd drwxr-xr-x /usr/share/doc/murmur-1.1.8 -rw-r--r-- /usr/share/doc/murmur-1.1.8/CHANGES -rw-r--r-- /usr/share/doc/murmur-1.1.8/LICENSE -rw-r--r-- /usr/share/doc/murmur-1.1.8/README -rw-r--r-- /usr/share/doc/murmur-1.1.8/README.Linux [makerpm@localhost SPECS]$ [makerpm@localhost SPECS]$ rpmlint ../RPMS/i386/murmur-1.1.8-2.fc9.i386.rpm murmur.i386: W: non-standard-uid /etc/rc.d/init.d/murmur murmur murmur.i386: W: non-standard-gid /etc/rc.d/init.d/murmur murmur murmur.i386: W: non-standard-uid /etc/murmur/murmur.ini murmur murmur.i386: W: non-standard-gid /etc/murmur/murmur.ini murmur murmur.i386: W: non-standard-uid /usr/bin/mumble-server murmur murmur.i386: W: non-standard-gid /usr/bin/mumble-server murmur murmur.i386: W: non-standard-uid /usr/sbin/murmur murmur murmur.i386: W: non-standard-gid /usr/sbin/murmur murmur murmur.i386: W: non-standard-uid /etc/mumble-server.ini murmur murmur.i386: W: non-standard-gid /etc/mumble-server.ini murmur murmur.i386: W: non-standard-uid /usr/sbin/murmurd murmur murmur.i386: W: non-standard-gid /usr/sbin/murmurd murmur murmur.i386: W: spurious-bracket-in-%preun 1 packages and 0 specfiles checked; 0 errors, 13 warnings. [makerpm@localhost SPECS]$ All those warnings are related to new user and group murmur:murmur. They shouldn't make any problems? But W13 is related to if[] in %preun. Tried to fix it but no success. Its something related to space before ]? ------------------------------------------------------------- SRPM: [makerpm@localhost SPECS]$ rpmlint ../SRPMS/mumble-1.1.8-2.fc9.src.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. [makerpm@localhost SPECS]$ ------------------------------------------------------------- SPEC: [makerpm@localhost SPECS]$ rpmlint mumble.spec 0 packages and 1 specfiles checked; 0 errors, 0 warnings. [makerpm@localhost SPECS]$ ------------------------------------------------------------- INIT: When I do /etc/init.d/murmur it throws me an error. Should I remove this line or fix it somehow? root /home/makerpm/rpmbuild/SPECS # /etc/init.d/murmur /etc/init.d/murmur: line 16: /lib/lsb/init-functions: No such file or directory Usage: <servicename> {start|stop|status|restart|reload|force-reload|condrestart root /home/makerpm/rpmbuild/SPECS # - fixed murmur.init. lockfile pointed to /var/log/subsys/murmur correct one is /var/lock/subsys/murmur --------------------------------------------------------------------- SPEC: http://78.46.84.75:81/tj/etmain/mumble/mumble.spec SRPM: http://78.46.84.75:81/tj/etmain/mumble/mumble-1.1.8-2.fc9.src.rpm NEW INIT: http://78.46.84.75:81/tj/etmain/mumble/murmur.init TODO: Install: icons - where, how...? scripts - should I add them as %doc or /usr/share/mumble/? desktop-file for mumble subpackage for mumble-overlay and desktop file - can somebody explain this a little bit more. As far as I see mumble-overlay is just bash script that preloads library before starting chosen program. Why would I create desktop file for script? Hmm, that's all? Review wanted. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review