Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: perl-HTML-FormatText-WithLinks - HTML to text conversion with links as footnotes https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204163 ------- Additional Comments From cweyl@xxxxxxxxxxxxxxx 2006-08-29 02:07 EST ------- Package is missing a couple BR's, but is good aside from that :) For the purposes of the review I'm assuming they're in there. Missing: perl(URI::WithBase) ...for testing: perl(Test::Pod::Coverage), perl(Test::Pod) These are the only blockers. + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. License text not included upstream. + source files match upstream: 77a18dd8ad57d2443827b2458b7e78dd HTML-FormatText-WithLinks-0.06.tar.gz 77a18dd8ad57d2443827b2458b7e78dd HTML-FormatText-WithLinks-0.06.tar.gz.srpm + latest version is being packaged. X BuildRequires are proper. O package builds cleanly in mock with additional BR's (5/x86_64) + rpmlint is silent. + final provides and requires are sane: ** perl-HTML-FormatText-WithLinks-0.06-1.fc5.noarch.rpm == rpmlint == provides perl(HTML::FormatText::WithLinks) = 0.06 perl-HTML-FormatText-WithLinks = 0.06-1.fc5 == requires perl(:MODULE_COMPAT_5.8.8) perl(HTML::TreeBuilder) perl(URI::WithBase) perl(base) perl(strict) perl(vars) + no shared libraries are present. + package is not relocatable. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + %clean is present. + %check is present and all tests pass: All tests successful. Files=15, Tests=62, 2 wallclock secs ( 1.46 cusr + 0.48 csys = 1.94 CPU) + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. + not a web app. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review