Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497525 Christoph Wickert <fedora@xxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |fedora@xxxxxxxxxxxxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Christoph Wickert <fedora@xxxxxxxxxxxxxxxxxxxx> 2009-04-24 21:46:50 EDT --- Thanks for this submission, I was thinking about packaging this just yesterday. IMO this package should be named gnome-applet-bublemon to follow the fedora naming conventions, see http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28General.29 You can add a provides for bubblemon-gnome if you like. The other bubblemon package from bug # 165483 should be renamed to bubblemon-dockapp because it violates the naming guidlines, but that's different issue. License: GPLv2 is not correct, this is GPLv2+, because if you look at the sourcecode you will find GPLv2 "or any later version". See https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#.22or_later_version.22_licenses BuildRequires: gettext is not really necessary, will be pulled in by intltool automatically. Remove "AutoReqProv: yes" & comment, it's a default that should not be mentioned explicitly. Also it wont work in this case: $ rpm -qp --requires bubblemon-gnome-2.0.13-2.fc10.i386.rpm | grep panel libpanel-applet-2.so.0 $ rpm -q --whatprovides libpanel-applet-2.so.0 gnome-panel-libs-2.24.3-2.fc10.i386 But gnome-panel-libs is not enough to actually run the applet, add "Requires: gnome-panel". Drop ABOUT-NLS again, generic info, not needed when installed from rpm. %{_mandir}/hu/man1/bubblemon-gnome2.1.gz and %{_mandir}/sv/man1/bubblemon-gnome2.1.gz are not utf-8, use iconv to convert them, see https://fedoraproject.org/wiki/PackageMaintainers/PackagingTricks#Convert_encoding_to_UTF-8 The rest looks good. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review