Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497593 --- Comment #6 from Andreas Thienemann <andreas@xxxxxxxxx> 2009-04-24 20:10:44 EDT --- Mandatory items =============== [ PASS ] MUST: rpmlint must be run on every package. rpmlint /var/lib/mock/fedora-rawhide-i386/result/*.rpm gnome-alsamixer.i586: W: non-conffile-in-etc /etc/gconf/schemas/gnome-alsamixer.schemas 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Warning is to be ignored [ OKAY ] MUST: The package must be named according to the Package Naming Guidelines. [ OKAY ] MUST: The spec file name must match the base package %{name}, in the format %{name}.spec unless your package has an exemption. [ OKAY ] MUST: The package must meet the Packaging Guidelines . [ OKAY ] MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. [ OKAY ] MUST: The License field in the package spec file must match the actual license. [ OKAY ] MUST: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package must be included in %doc. [ OKAY ] MUST: The spec file must be written in American English. [ OKAY ] MUST: The spec file for the package MUST be legible. [ TODO ] MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. 671ac31745fe4a8d4c40c18f6a5fd1aa gnome-alsamixer-20090424gitc540b26.tar.bz2 This has been verified to correspond to git sha1 c540b26. Please include specifics on generating the tarball. See https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control [ OKAY ] MUST: The package MUST successfully compile and build into binary rpms on at least one primary architecture. Build successfully on i586, ppc, ppc64 and x86_64 [ NOOP ] MUST: If the package does not successfully compile, build or work on an architecture, then those architectures should be listed in the spec in ExcludeArch. Each architecture listed in ExcludeArch MUST have a bug filed in bugzilla, describing the reason that the package does not compile/build/work on that architecture. The bug number MUST be placed in a comment, next to the corresponding ExcludeArch line. [ OKAY ] MUST: All build dependencies must be listed in BuildRequires, except for any that are listed in the exceptions section of the Packaging Guidelines ; inclusion of those as BuildRequires is optional. [ OKAY ] MUST: The spec file MUST handle locales properly. [ NOOP ] MUST: Every binary RPM package (or subpackage) which stores shared library files (not just symlinks) in any of the dynamic linker's default paths, must call ldconfig in %post and %postun. [ NOOP ] MUST: If the package is designed to be relocatable, the packager must state this fact in the request for review, along with the rationalization for relocation of that specific package. Without this, use of Prefix: /usr is considered a blocker. [ OKAY ] MUST: A package must own all directories that it creates. If it does not create a directory that it uses, then it should require a package which does create that directory. [ OKAY ] MUST: A Fedora package must not list a file more than once in the spec file's %files listings. [ OKAY ] MUST: Permissions on files must be set properly. Executables should be set with executable permissions, for example. Every %files section must include a %defattr(...) line. [ OKAY ] MUST: Each package must have a %clean section, which contains rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [ OKAY ] MUST: Each package must consistently use macros. [ OKAY ] MUST: The package must contain code, or permissable content. [ NOOP ] MUST: Large documentation files must go in a -doc subpackage. [ NOOP ] MUST: If a package includes something as %doc, it must not affect the runtime of the application. [ NOOP ] MUST: Header files must be in a -devel package. [ NOOP ] MUST: Static libraries must be in a -static package. [ NOOP ] MUST: Packages containing pkgconfig(.pc) files must 'Requires: pkgconfig' (for directory ownership and usability). [ NOOP ] MUST: If a package contains library files with a suffix (e.g. libfoo.so.1.1), then library files that end in .so (without suffix) must go in a -devel package. [ NOOP ] MUST: In the vast majority of cases, devel packages must require the base package using a fully versioned dependency. [ OKAY ] MUST: Packages must NOT contain any .la libtool archives, these must be removed in the spec if they are built. [ TODO ] MUST: Packages containing GUI applications must include a %{name}.desktop file, and that file must be properly installed with desktop-file-install in the %install section. desktop-file-install is not used. [ OKAY ] MUST: Packages must not own files or directories already owned by other packages. [ OKAY ] MUST: At the beginning of %install, each package MUST run rm -rf %{buildroot} (or $RPM_BUILD_ROOT). [ OKAY ] MUST: All filenames in rpm packages must be valid UTF-8. Optional items ============== [ NOOP ] SHOULD: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [ PASS ] SHOULD: The description and summary sections in the package spec file should contain translations for supported Non-English languages, if available. [ OKAY ] SHOULD: The reviewer should test that the package builds in mock. [ OKAY ] SHOULD: The package should compile and build into binary rpms on all supported architectures. [ OKAY ] SHOULD: The reviewer should test that the package functions as described. [ TODO ] SHOULD: If scriptlets are used, those scriptlets must be sane. [ NOOP ] SHOULD: Usually, subpackages other than devel should require the base package using a fully versioned dependency. [ NOOP ] SHOULD: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. [ NOOP ] SHOULD: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. Notes ===== Package is mostly fine. See the attached patch, it fixes some minor issues such as the missing desktop-file-install usage and the correct source URL. Please apply. ToDo List ========= * Describe the processs of generating the tarball (e.g. rm -rf .git) * Use desktop-file-install (in patch) * Add error handler to %post handler (in patch) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review