Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=496633 --- Comment #3 from Mauricio Henriquez <buhochileno@xxxxxxxxx> 2009-04-23 16:56:58 EDT --- First the doubts: you say: "* Package is named according to the naming Guidelines" My packages don't end with .fc10.rpm , don't know how to instruct rpmbuild to use that kind of name convention. On "*Needswork" section you say: "* All filenames are UTF-8", that is good or bad?, need to change the text encoding? Fixed: * Spec file readability - DONE * License tag should just be "MIT" - DONE * The Source: line needs to have the full URL to the source - DONE * The vendor: tag should not be present in Fedora specfiles. - DONE * Autoreqprov should normally not be in Fedora spec files. - DONE * BuildArch: i386 does not belong in the spec file: Here some doubts don't know if this addins are goin to compile fine in all architectures, it seems to me that it have to just x86/x86_64 for now, how do I mix the "BuildArch: noarh" and "ExclusiveArch: x86 x86_64"? * env_options isn't a macro used in Fedora - DONE * You should use %configure rather than ./configure: Problem here, using "%configure" I get: ind-tables -I/usr/lib/gfortran/modules' + export FFLAGS + ./configure --build=i686-pc-linux-gnu --host=i686-pc-linux-gnu --target=i386-redhat-linux-gnu --program-prefix= --prefix=/usr --exec-prefix=/usr --bindir=/usr/bin --sbindir=/usr/sbin --sysconfdir=/etc --datadir=/usr/share --includedir=/usr/include --libdir=/usr/lib --libexecdir=/usr/libexec --localstatedir=/var --sharedstatedir=/var/lib --mandir=/usr/share/man --infodir=/usr/share/info Unknown argument --build=i686-pc-linux-gnu Usage : configure [OPTION]... [--config=CONFIG] So, it seems to me that the "%configure" macro use something that the package script don't know, so I use again "./configure" witch give now a error message: RPM build errors: File not found by glob: /home/buho/rpmbuild/BUILDROOT/monodevelop-debugger-gdb-2.0-1.1.i386/usr/lib/lib/monodevelop/AddIns/MonoDevelop.Debugger/MonoDevelop.Debugger.Gdb.dll* Witch is related to the use of: %{_libdir}/lib/monodevelop/AddIns/MonoDevelop.Debugger/MonoDevelop.Debugger.Gdb.dll* instead of the original: %{_prefix}/lib/monodevelop/AddIns/MonoDevelop.Debugger/MonoDevelop.Debugger.Gdb.dll* * --prefix=%_prefix is included in the %configure macro so you don't need it if you use the %configure macro. - SEE PREVIOUS * In Fedora, mono libraries are installed in %{_libdir} instead of /usr/lib. On x86_64 systems, that expands to /usr/lib6 instead of /usr/lib.- SEE PREVIOUS * package needs to rm -rf %{buildroot} at the beginning of %install - DONE * All filenames are UTF-8 - GOOD/BAD? * No license file is included in the tarball so you should ask upstream if they'll provide one with their next release. - ASKING * Looks like you need to BuildRequire: monodevelop-devel rather than monodevelop. - DONE Reviewed file can be found: http://www.ic.uach.cl/mhenriquez/fedora10-monoRPMS/monodevelop-debugger-gdb.spec.review1 Thanks Toshio Mauricio -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review