Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497310 --- Comment #4 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-04-23 10:57:34 EDT --- (In reply to comment #2) > compatibility_tests is a php page designed to display via a webserver whether > or not your machine has the prerequisites (ie php 4.3 or greater) to use > SimplePie. > > If you think it more appropriate, I can move it to %doc OK, no need to ship it then. But no need to delete it either! > I'll remove the extra requires and push a new spec/srpm up shortly. OK. - Use %{version} in Source0 line - You are still mixing $RPM_BUILD_ROOT and %{buildroot}. This is a blocker. - Don't use a macro for mkdir, it's silly and makes the spec file harder to read. - Move the chmod's to the setup phase, since they're not related to the install phase - Don't remove compatibility_test, since it's not going anywhere from the builddir. [- You can copy both create.php and simplepie.inc in a single line.] -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review