Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497310 --- Comment #1 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-04-23 10:31:42 EDT --- - No need to Requires: php since it is already pulled in by php-IDNA_Convert. - Why do you "rm -rf compatibility_test"? rpmlint output is clean. MUST: The package does not yet exist in Fedora. The Review Request is not a duplicate. OK MUST: The spec file for the package is legible and macros are used consistently. NEEDSFIX - Don't mix $RPM_BUILD_ROOT and %{buildroot}. Choose one and stick with it. - You could clean up the install phase by replacing %{__mkdir} -p %{buildroot}/%{_datadir}/php/%{name} cp -a create.php %{buildroot}/%{_datadir}/php/%{name}/ cp -a simplepie.inc %{buildroot}/%{_datadir}/php/%{name}/ with install -D -p -m 644 create.php %{buildroot}/%{_datadir}/php/%{name}/create.php install -D -p -m 644 simplepie.php %{buildroot}/%{_datadir}/php/%{name}/simplepie.php MUST: The package must be named according to the Package Naming Guidelines. OK - No PECL, PEAR or CHANNEL. MUST: The spec file name must match the base package %{name}. OK MUST: The package must be licensed with a Fedora approved license and meet the Licensing Guidelines. OK MUST: The License field in the package spec file must match the actual license. OK - simplepie.inc contains BSD headers. MUST: The sources used to build the package must match the upstream source, as provided in the spec URL. OK MUST: Optflags are used and time stamps preserved. OK MUST: A package must own all directories that it creates or require the package that owns the directory. OK MUST: Files only listed once in %files listings. OK MUST: Permissions on files must be set properly. OK MUST: Clean section exists. OK MUST: Large documentation files must go in a -doc subpackage. OK MUST: All relevant items are included in %doc. Items in %doc do not affect runtime of application. OK MUST: No file conflicts with other packages and no general names. OK MUST: Buildroot cleaned before install. OK SHOULD: %{?dist} tag is used in release. OK SHOULD: If the package does not include license text(s) as separate files from upstream, the packager should query upstream to include it. OK SHOULD: The package builds in mock. OK -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review