Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497283 --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2009-04-23 06:59:52 EDT --- Review: + package builds in mock (rawhide i586). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1316294 + rpmlint output is for SRPM and for RPM. perl-Syntax-Highlight-Engine-Kate.noarch: E: useless-provides perl(Syntax::Highlight::Engine::Kate::Alerts) ==> you should filter this + source files match upstream url 7f94ab9430a4c8504bb93c7974bb7493 Syntax-Highlight-Engine-Kate-0.04.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=1, Tests=528, 99 wallclock secs ( 0.21 usr 0.01 sys + 96.32 cusr 0.21 csys = 96.75 CPU) Suggestions: 1) you should remove OPTIMIZE="$RPM_OPT_FLAGS" And find $RPM_BUILD_ROOT -type f -name '*.bs' -size 0 -exec rm -f {} \; from SPEC as this is noarch package. 2) You must replace %attr(0644,root,root) /usr/lib/perl5/vendor_perl/5.10.0/Syntax/Highlight/Engine/Kate.pm %attr(0644,root,root) /usr/lib/perl5/vendor_perl/5.10.0/Syntax/Highlight/Engine/Kate.pod %attr(0644,root,root) /usr/lib/perl5/vendor_perl/5.10.0/Syntax/Highlight/Engine/Kate/* to %{perl_vendorlib}/* 3) When I filtered either one provides from perl(Syntax::Highlight::Engine::Kate::Alerts) = 0.01 perl(Syntax::Highlight::Engine::Kate::Alerts) = 0.03 Got Unknown arguments to TAP::Harness::new (ignore_exit) at /usr/lib/perl5/5.10.0/Test/Harness.pm line 255 maybe Ralf can help to fix this here. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review