Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: cyphesis - WorldForge game server https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=200976 ------- Additional Comments From paul@xxxxxxxxxxxxxxxxxxxxxx 2006-08-28 16:39 EST ------- Okay, this builds happily in mock, rpmlint is clean and I'm happy with the IPv6 statement in #27 Review time... Comment... %package selinux Requires(post): /usr/sbin/ Should be %{_sbindir} really, it's not a blocker though as you've used /usr/sbin throughout. Needs work %files all the %{_bindir} files can be globbed %{_bindir}/cy* You don't have a %files devel (that I can see) yet you have the subpackage defined in the spec. Good Everything else! No dupes in the rpms build The software works Spec file complies with the packaging guidelines Permissions correctly set rpmlint clean mock builds fine (i386) Has fallback if selinux is not available/enabled md5sums correspond Consistent use of macros throughout Fix the needs work section and I'm happy. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review