Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=497140 --- Comment #3 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2009-04-23 02:05:53 EDT --- (In reply to comment #2) > (In reply to comment #1) > > - Does the package work with php4? Maybe a version could be added to Requires: > > php >=5. > > This does work with php 4.3 and later per the internal comments. I'll be happy > to add the requires with a version though since for current version of Fedora > php5 is the only option. Okay, then it's no problem. > > MUST: The package must be licensed with a Fedora approved license and meet the > > Licensing Guidelines. NEEDSFIX > > - According to idna_convert.class.php license is LGPLv2+ not LGPLv2. Other php > > files do not contain any license specifications. > > The 'LICENCE' file included with the software distribution is LGPLv2, and given > the lack of licensing for the rest of the .php files this leads me to believe > that these are LGPLv2 and that thusly the package should be LGPLv2 instead of > LGPLv2+. I am open to correction on this point, though, but this is my > understanding. See https://fedoraproject.org/wiki/Licensing/FAQ#How_do_I_figure_out_what_version_of_the_GPL.2FLGPL_my_package_is_under.3F I think it has been mentioned also somewhere more visible in the guidelines, but I didn't find it in a couple of minutes. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review