Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488100 --- Comment #59 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2009-04-22 00:17:20 EDT --- (In reply to comment #57) > All builds are ok > > http://koji.fedoraproject.org/koji/taskinfo?taskID=1311836 > > http://ibphoenix.fr/fedora/firebird.spec > http://ibphoenix.fr/fedora/firebird-2.1.2.18118.0-2.fc10.src.rpm > upgraded > > Seems that now rpmlint results are better > I shouldn't trust as much the previous work that was made ;) Ok, we almost finished. But few issues still remains: * Do not use grep while searching for users and grups. Although you're searching for already created user in a correct way, your attempt to check whether or not firebird group exists needs fixing. See comments from Pavel, https://bugzilla.redhat.com/show_bug.cgi?id=488100#c17 and from Wart, https://bugzilla.redhat.com/show_bug.cgi?id=488100#c18 . I suggest you to use getent group %{name} instead if grepping /etc/group. - grep -q %{name} /etc/group || /usr/sbin/groupadd -r %{name} || true + getent group %{name} || /usr/sbin/groupadd -r %{name} || true * I don't fully understand "|| true" at the end of oneliners for safe user/group creation. Are you assuming that there is a chance that user/group creation will fail? Should we simply abort installation in this case? I'm waiting for scratchbuild at F-10 ( http://koji.fedoraproject.org/koji/taskinfo?taskID=1313853 ), but seems that trick with autoreconf works. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review