[Bug 496777] Review Request: perl-MooseX-MethodAttributes - Introspect your code attributes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=496777


Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
               Flag|fedora-review?              |fedora-review+




--- Comment #2 from Parag AN(पराग) <panemade@xxxxxxxxx>  2009-04-21 03:15:40 EDT ---
Review:
+ package builds in mock (rawhide i386).
koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=1310695
+ rpmlint is silent for SRPM and for RPM.
+ source files match upstream url
9db312b0fe2b5311aac1f7c68b3133df  MooseX-MethodAttributes-0.06.tar.gz
+ package meets naming and packaging guidelines.
+ specfile is properly named, is cleanly written
+ Spec file is written in American English.
+ Spec file is legible.
+ dist tag is present.
+ build root is correct.
+ license is open source-compatible.
+ License text is included in package.
+ %doc is present.
+ BuildRequires are proper.
+ %clean is present.
+ package installed properly.
+ Macro use appears rather consistent.
+ Package contains code, not content.
+ no headers or static libraries.
+ no .pc file present.
+ no -devel subpackage
+ no .la files.
+ no translations are available
+ Does owns the directories it creates.
+ no scriptlets present.
+ no duplicates in %files.
+ file permissions are appropriate.
+ make test gave
All tests successful.
Files=3, Tests=12,  2 wallclock secs ( 0.05 usr  0.01 sys +  1.86 cusr  0.06
csys =  1.98 CPU)
+ Package perl-MooseX-MethodAttributes-0.06-2.fc11.noarch =>
  Provides: perl(MooseX::MethodAttributes) = 0.06
perl(MooseX::MethodAttributes::Inheritable) = 0.06
perl(MooseX::MethodAttributes::Role::AttrContainer) = 0.06
perl(MooseX::MethodAttributes::Role::AttrContainer::Inheritable) = 0.06
perl(MooseX::MethodAttributes::Role::Meta::Class) = 0.06
perl(MooseX::MethodAttributes::Role::Meta::Method) = 0.06
perl(MooseX::MethodAttributes::Role::Meta::Method::MaybeWrapped) = 0.06
perl(MooseX::MethodAttributes::Role::Meta::Method::Wrapped) = 0.06

Requires: perl(Moose) perl(Moose::Exporter) perl(Moose::Role) perl(Moose::Util)
perl(Moose::Util::MetaRole)
perl(MooseX::MethodAttributes::Role::Meta::Method::Wrapped)
perl(MooseX::Types::Moose) perl(namespace::clean) perl(strict) perl(warnings)

APPROVED.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]