Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request:perl-File-NFSLock - Perl module to do NFS (or not) locking https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=204151 ------- Additional Comments From cweyl@xxxxxxxxxxxxxxx 2006-08-28 02:02 EST ------- I see there's an examples directory/script, but it's not included in %doc. Let's include that, and this package is approved. + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written and uses macros consistently. + dist tag is present. + build root is correct. + license field matches the actual license. + license is open source-compatible. License text not included upstream. + source files match upstream: 68bddc5e2c32d9748ae689f398fc1147 File-NFSLock-1.20.tar.gz 68bddc5e2c32d9748ae689f398fc1147 File-NFSLock-1.20.tar.gz.srpm + latest version is being packaged. + BuildRequires are proper. + package builds in mock (5/x86_64) + rpmlint is silent. + final provides and requires are sane: ** perl-File-NFSLock-1.20-1.fc5.noarch.rpm == rpmlint == provides perl(File::NFSLock) = 1.20 perl-File-NFSLock = 1.20-1.fc5 == requires perl(:MODULE_COMPAT_5.8.8) perl(Carp) perl(Exporter) perl(strict) perl(vars) + package is not relocatable. + owns the directories it creates. + doesn't own any directories it shouldn't. + no duplicates in %files. + file permissions are appropriate. + %clean is present. + %check is present and all tests pass: All tests successful. Files=12, Tests=161, 42 wallclock secs ( 0.69 cusr + 0.82 csys = 1.51 CPU) + no scriptlets present. + code, not content. + documentation is small, so no -docs subpackage is necessary. + %docs are not necessary for the proper functioning of the package. + no headers. + no pkgconfig files. + no libtool .la droppings. + not a GUI app. + not a web app. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review