Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=483364 --- Comment #12 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2009-04-20 15:01:22 EDT --- Some notes: * %define -> %global - For some reasons (especially due to rpm's "unexpected" behaviour with nested macros), Fedora now suggests to use %global instead of %define: https://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define * Including additional documents as Source - When including additional documents, please add them as Sources instead of making patch, like: ----------------------------------------------------------------- Source1: README.postgres ..... ..... %prep %setup -q %patch0 -p0 -b .script cp -p %SOURCE1 . ----------------------------------------------------------------- (Also see the below comments about timestamps) * Dependency between subpackages - Usually the dependency between packages rebuilt from the same srpm is strict EVR (Epoch-Version-Release) specific (not only version specific): https://fedoraproject.org/wiki/Packaging/Guidelines#Requiring_Base_Package ! %setup - "-n %{name}-%{version}" is the default of %setup, so "%setup -q" is enough here. * Timestamps - When using "cp" or "install" commands, use "-p" option to keep timestamps on installed files: https://fedoraproject.org/wiki/Packaging/Guidelines#Timestamps * Permission ----------------------------------------------------------------- %{__find} blib/lib ! -type d -printf "%{__install} -m 0444 %p %{buildroot}%{ebshare}/lib/%%P\n" | sh -x ----------------------------------------------------------------- - Usually these files should have 0644 permission. * %files ----------------------------------------------------------------- # Collect the list of files. Basically we include all files except # the EB/DB (database specific) modules. ( cd %{buildroot}; %{__find} ./%{ebshare} -type d -printf "%%%%dir %{ebshare}/%%P\n"; %{__find} ./%{ebshare} -type f -printf "%{ebshare}/%%P\\n" | %{__grep} -v "lib/EB/DB/.*pm" ) > .files # Include the SQLite driver. echo '%{ebshare}/lib/EB/DB/Sqlite.pm' >> .files ----------------------------------------------------------------- - The following is much simpler: ----------------------------------------------------------------- %files %defattr(-,root,root,-) %doc ....... %dir %{_sysconfdir}/%{lcname} %config(noreplace) %{_sysconfdir}/%{lcname}/%{lcname}.conf %{ebshare}/ %exclude %{ebshare}/lib/EB/DB/Postgres.pm %{_bindir}/ebshell %{_mandir}/man1/* %files db-postgresql %defattr(-,root,root,-) %doc README.postgres %{ebshare}/lib/EB/DB/Postgres.pm ----------------------------------------------------------------- * Documents - Usually the file "INSTALL" is for people who want to install the package by themselves and not needed for rpm users. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review