[Bug 478917] Review Request: globus-xio - Globus Toolkit - Globus XIO Framework

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=478917





--- Comment #5 from Mattias Ellert <mattias.ellert@xxxxxxxxxxxx>  2009-04-18 16:33:51 EDT ---
(In reply to comment #4)
> Fedora review globus-xio-2.7-1.fc10.src.rpm 2008-04-18
> 
> (btw: the posted spec file and the spec file contained in the srpm are not
> consistent)

Sorry about that. It seems I copied the last version of the SRPM to the server
with the wrong name after the last update - so the previous one was not
overwritten as I intended. The difference between the versions was that I added
globus-common as a Requires so that the package Requires a package that owns
the direcories where it puts its files. I have updated the SRPM with the
intended one. The specfile was the intended one.

> + OK
> ! needs attention
> 
> ! rpmlint output (including the license file as doc gets rid of the warning)

I just removed the license file as doc in this version since a reviewer of a
different package strongly argued that it shouldn't be there since it is not
part of the source tree for this package (see bug 467235 comment 3). I really
need all the packages to be the same, otherwise it is not maintainable. If you
strongly disagree with the previous reviewer, I will try to do some
arbitration.

> ! The package contains the license file

See above

> ! Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig'

globus-xio-devel Requires globus-core, which Requires pkgconfig.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]