Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488100 --- Comment #35 from Philippe Makowski <makowski.fedora@xxxxxxxxx> 2009-04-18 04:27:04 EDT --- (In reply to comment #33) > ** completely remove %{major}, %{minor} macros - just use %{version} macro. > ** remove "%global version %{major}.%{minor}" as well. No need to re-define > this macro. > ** combine %{pkgname} and %{pkgversion} together (since they used only in > couple) > - Please, do not use %{?dist}-suffixes in changelog. This also a minor issue. all done, thanks check here : http://ibphoenix.fr/fedora/firebird.spec http://ibphoenix.fr/fedora/firebird-2.1.2.18118.0-1.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review