Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488100 --- Comment #33 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2009-04-17 04:36:55 EDT --- Notes: - The issue with excessive number of macros still not addressed. I advice you to ** completely remove %{major}, %{minor} macros - just use %{version} macro. ** remove "%global version %{major}.%{minor}" as well. No need to re-define this macro. ** combine %{pkgname} and %{pkgversion} together (since they used only in couple) In any case, these issues are cosmetic, mostly. + The issue with iconv was gone. - Please, do not use %{?dist}-suffixes in changelog. This also a minor issue. More nites will be after I rebuild the package in koji. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review