Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=492133 --- Comment #4 from Kalev Lember <kalev@xxxxxxxxxxxx> 2009-04-16 09:15:57 EDT --- Fedora review mingw32-libglade2-2.6.4-1.fc11.src.rpm 2008-04-16 + OK ! needs attention + rpmlint output Only expected Errors/Warnings from a Mingw32 package + Package is named according to Fedora MinGW packaging guidelines + Specfile name matches the package base name ! Package follows the Fedora MinGW packaging guidelines Right now static subpackage's requires line is: Requires: %{name} = %{version} But instead it should read: Requires: %{name} = %{version}-%{release} + License meets guidelines and is acceptable to Fedora LGPLv2+ + License matches the actual package license It is also the same as in the corresponding Fedora libglade2 package + The package contains the license file (COPYING) + Spec file is written in American English + Spec file is legible + Upstream sources match sources in the srpm d1776b40f4e166b5e9c107f1c8fe4139 libglade-2.6.4.tar.bz2 d1776b40f4e166b5e9c107f1c8fe4139 SRPM/libglade-2.6.4.tar.bz2 + Package builds in mock (Fedora Rawhide i586) n/a ExcludeArch bugs filed + BuildRequires list all build dependencies n/a %find_lang instead of %{_datadir}/locale/* n/a binary RPM with shared library files must call ldconfig in %post and %postun + Does not use Prefix: /usr + Package owns all directories it creates + No duplicate files in %files + %files has %defattr + %clean contains rm -rf $RPM_BUILD_ROOT + Consistent use of macros + Package must contain code or permissible content n/a Large documentation files should go in -doc subpackage + Files marked %doc should not affect package n/a Header files should be in -devel Fedora MinGW guidelines allow headers in main package + Static libraries should be in -static + Packages containing pkgconfig (.pc) files need 'Requires: pkgconfig' n/a libfoo.so must go in -devel n/a -devel must require the fully versioned base n/a Packages should not contain libtool .la files Fedora MinGW guidelines allow .la files n/a Packages containing GUI apps must include %{name}.desktop file + Packages must not own files or directories owned by other packages + %install begins with rm -rf $RPM_BUILD_ROOT + Filenames must be valid UTF-8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review