Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=488174 Christoph Wickert <fedora@xxxxxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fedora@xxxxxxxxxxxxxxxxxxxx --- Comment #5 from Christoph Wickert <fedora@xxxxxxxxxxxxxxxxxxxx> 2009-04-16 05:52:49 EDT --- I think you should split this into subpackes, so it can be used by other desktop environments as well without installing the Gnome bits. - gtk-nimbus-engine (arch, includes libnimbus.so and gtkrc, requires gtk-engines for dir ownership) - nimbus-icon-theme (noarch, contains all the icons, requires hicolor-icon theme for dir ownership) - nimbus-metacity-theme (noarch, includes %{_datadir}/themes/nimbus/metacity-1, requires metacity) - nimbus-theme-gnome (noarch, requires all the others and only includes index.theme) More issues/suggestions: - Group should be User Interface/X or UserInterface/Desktops - %configure --disable-static and drop the devel package - %{nimbus_dir}/index.theme is listed twice in %files section. Once as %{nimbus_dir}/index.theme and once as content of in %{_datadir}/themes/nimbus/ - don't use a define for %{nimbus_dir} because it makes %files more complicated (as the duplicate index.theme proves), it's only used twice in the spec and will most likely never change. - preserve timestamp during iconv, see https://fedoraproject.org/wiki/PackageMaintainers/PackagingTricks#Convert_encoding_to_UTF-8 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review