Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: kdiff3: Compare + merge 2 or 3 files or directories https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=191473 j.w.r.degoede@xxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bugzilla-sink@xxxxxxxxxxxxx |j.w.r.degoede@xxxxxx OtherBugsDependingO|163776 |163778 nThis| | ------- Additional Comments From j.w.r.degoede@xxxxxx 2006-08-27 04:21 EST ------- As promised a formal review, one the must fixes are fixed we can do tihs for one or two of your other packages, once I'm convinced that you've got the hang of things I'll sponsor you. MUST: ===== O rpmlint output is: W: kdiff3 mixed-use-of-spaces-and-tabs W: kdiff3 incoherent-version-in-changelog 0.9.88-5 0.9.90-5 W: kdiff3 dangling-relative-symlink /usr/share/doc/HTML/de/kdiff3/common ../common W: kdiff3 dangling-relative-symlink /usr/share/doc/HTML/fr/kdiff3/common ../common W: kdiff3 dangling-relative-symlink /usr/share/doc/HTML/nl/kdiff3/common ../common W: kdiff3 dangling-relative-symlink /usr/share/doc/HTML/en/kdiff3/common ../common W: kdiff3 dangling-relative-symlink /usr/share/doc/HTML/pt/kdiff3/common ../common W: kdiff3 dangling-relative-symlink /usr/share/doc/HTML/it/kdiff3/common ../common W: kdiff3 dangling-relative-symlink /usr/share/doc/HTML/da/kdiff3/common ../common W: kdiff3 dangling-relative-symlink /usr/share/doc/HTML/es/kdiff3/common ../common W: kdiff3 dangling-relative-symlink /usr/share/doc/HTML/sv/kdiff3/common ../common W: kdiff3 dangling-relative-symlink /usr/share/doc/HTML/et/kdiff3/common ../common * Package and spec file named appropriately * Packaged according to packaging guidelines * License ok (but license file not included!) * spec file is legible and in Am. English. * Source matches upstream * Compiles and builds on devel x86_64 * BR: ok * Locales handled as required * No shared libraries * Not relocatable * Package owns / or requires all dirs * No duplicate files & Permissions ok * %clean & macro usage OK * Contains code only * %doc does not affect runtime, and isn't large enough to warrent a sub package * no -devel package needed, no libs / .la files(except for the plugin). * .desktop file as required, but not properly installed, see below MUST Fix ======== * The following rpmlint output: W: kdiff3 mixed-use-of-spaces-and-tabs W: kdiff3 incoherent-version-in-changelog 0.9.88-5 0.9.90-5 * The desktop-file-install command is missing "--add-category X-Fedora" from its argument list * The %post / %postun scriptlets are not updating the gtk-icon-cache, causing the icon to not appear in the gnome-panel menu, please use the full scriptlets for this as given here: http://fedoraproject.org/wiki/Packaging/ScriptletSnippets?action=show&redirect=ScriptletSnippets#head-7103f6c38d1b5735e8477bdd569ad73ea2c49bda * Remove this (already commented) bogus line from %files: "#%{_datadir}/locale" * Replace the empty %doc with: %doc AUTHORS COPYING ChangeLog README TODO and move the line to directly below the %defattr line. Also remove the empty line between %{_datadir}/services/* and %{_mandir}/man1/kdiff3* a manfile is treated as a normal file. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review