Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: libburn - Library for reading, mastering and writing optical discs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=203964 ------- Additional Comments From jwilson@xxxxxxxxxx 2006-08-27 00:10 EST ------- Okay, first run through the spec... FIXME's: 1) per the pre-release package naming conventions at http://fedoraproject.org/wiki/Packaging/ NamingGuidelines, I believe the Release: ought to be 0.1.20060823svn%{?dist} 2) The tarball contains %doc-worthy material. These files need to be added to one of the packages: AUTHORS COPYING COPYRIGHT README, probably just to the main libburn package. 3) the 'mixed spaces and tabs' error can be remedied by replacing the tabs in cdrskin's Version: and Release: lines with spaces. 4) the rpmlint shellbang warnings appear to be due to everything in libisofs/ having execute permissions, an extra line in the spec can take care of it. Doesn't matter if its done in the spec or by hand in this case, since you created the svn tarball, but I think its ultimately better to do it in the spec, just in case the upstream 0.2 release still has execute bits set, so you don't have to modify an upstream release tarball in the future. Certainly holler at them to get that fixed though... 5) the Requires: in cdrskin needs to be corrected, it'll currently result in cdrskin requiring libburn 0.1.4. 6) I'd leave off the Release: field in cdrskin, since its redundant. 7) might want to use %{mainver} in more places, to avoid winding up with conflicting version numbers here and there (that different version on cdrskin certainly does make life interesting...). With some minor spec tweaks, I've got the rpmlint spew down to a minimum now, all ignorable warnings: $ rpmlint /build/RPMS/x86_64/*0.1.20060823*.rpm W: cdrskin no-documentation W: libburn-devel no-documentation W: libisofs no-documentation W: libisofs-devel no-documentation Spec diff (not directly applicable, since the tabs copied as spaces, just provided "for your viewing pleasure ;): --- libburn.spec.orig 2006-08-24 14:38:14.000000000 -0400 +++ libburn.spec 2006-08-27 00:06:16.000000000 -0400 @@ -2,8 +2,8 @@ # define this as version gets overridden by the subpackage with its own version Name: libburn -Version: 0.2 -Release: 1.20060823svn%{?dist} +Version: %{mainver} +Release: 0.1.20060823svn%{?dist} Summary: Library for reading, mastering and writing optical discs Group: System Environment/Libraries @@ -60,9 +60,8 @@ %package -n cdrskin Summary: Limited cdrecord compatibility wrapper to ease migration to libburn Group: Applications/Multimedia -Version: 0.1.4 -Release: 1.20060823svn%{?dist} -Requires: %{name} = %{version}-%{release} +Version: 0.1.4 +Requires: %{name} = %{mainver}-%{release} %description -n cdrskin A limited cdrecord compatibility wrapper which allows to use some libburn @@ -71,6 +70,8 @@ %prep %setup -n %{name}-%{mainver}svn -q +# These shouldn't be executable... +chmod -x libisofs/* %build @@ -102,7 +103,7 @@ %files %defattr(-,root,root,-) -%doc +%doc AUTHORS COPYING COPYRIGHT README %{_libdir}/%{name}*.so.* %files devel @@ -131,5 +132,5 @@ %changelog -* Wed Aug 23 2006 Jesse Keating <jkeating@xxxxxxxxxx> - 0.2-1.20060823svn +* Wed Aug 23 2006 Jesse Keating <jkeating@xxxxxxxxxx> - 0.2-0.1.20060823svn - Initial package for review -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review