Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=493750 --- Comment #3 from David Lutterkort <lutter@xxxxxxxxxx> 2009-04-15 14:10:05 EDT --- Sorry for the lag, somehow your review got filed into the wrong mail folder. (In reply to comment #1) > * Your home page points to a changed "URL: https://fedorahosted.org/netcf/"; Fixed. > * Better summary: Cross-platform network configuration library > (taken from README!) Thanks; indeed much better. > * Fedora 10 build needs augeas >= 0.5.0 from updates-testing Yeah, it just got pushed to updates > * Build errors on Fedora 10: > [...] > checking for LIBAUGEAS... yes > checking for LIBXML... > [...] > > => Missing BuildRequires: libxml2-devel > > > checking for LIBXSLT... > > => Missing BuildRequires: libxslt-devel > (this requires libxml2-devel, too) Added those BR's > * In "src" directory, NETCF_CFLAGS duplicates the CFLAGS. I don't see that - do you mean the duplication of -I/usr/include/libxml2 ? That comes from using cflags from both libxml2 and libxslt; though since netcf uses API's from both, i.e. it doesn't just use libxml2 via libxslt, I'd rather leave the explicit LIBXML_CFLAGS in the Makefile. > * netcf.pc file is missing "Requires: augeas" because it contains "-laugeas". Ok, I am adding a Requires for augeas, libxslt, and libxml-2.0 to netcf.pc and taking out the -laugeas. I'll post an updated spec/srpm in a minute. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review