Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=495411 --- Comment #6 from Pavel Alexeev (aka Pahan-Hubbitus) <pahan@xxxxxxxxxxxxx> 2009-04-15 04:43:44 EDT --- (In reply to comment #5) > Isn't it iso-8859-1 ? Just guessing. I even have no idea about it! > you don't need to install them explicitly in %install > It's enough to put *.java to %doc. Actually, when you put *.java to %doc, it > will copy them one more time and the above installation will get overriden. Ok. Thank you for the hint. Fixed. > Yes. > License: BSD and MIT Ok, license changed. > jce is provided by both java-1.6.0-openjdk and java-1.5.0-gcj. Adding BR:jce > (without a version) will pull java-1.5.0-gcj, which is already being pulled by > BR: java-gcj-compat-devel >= 1.0.31. Also, java-1.6.0-openjdk is pulled via > java-devel >= 1.7 anyways. > > java-javadoc is not needed during the building of the package. The guidelines > forbid unnecessary BR's. Ok, I delete its. Thank you for the explanation. > > > * BR: jpackage-utils is listed twice. > > Fixed. > > > > It's still there. I guess you removed R: jpackage-utils instead. Sory for mistake. Fixed (again :) ) > Other than these, the package does not build with gcj. So, in this case all work to add conditional GCJ build is nought??? > You need to add > BR: java-devel >= 1.7 > also > R: java >= 1.7 Added. > (I'm confused. Didn't you have these before already? Did you remove them?) I don't rememeber. I think no. (Sorry, I add it into my svn repository too late - when review was already in progress and can't say exact) And what is more strange: This package builded fine on my local machine, but failed in koji (http://koji.fedoraproject.org/koji/taskinfo?taskID=1299756) on %check stage. May be internet connection not available in mock chroot?? Any suggestions? http://hubbitus.net.ru/rpm/Fedora9/dnsjava/dnsjava-2.0.6-4.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review